Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛compatible with vConsole who will wrap global variables with proxy #2630

Merged
merged 2 commits into from
Aug 23, 2023
Merged

🐛compatible with vConsole who will wrap global variables with proxy #2630

merged 2 commits into from
Aug 23, 2023

Conversation

kuitos
Copy link
Member

@kuitos kuitos commented Aug 23, 2023

@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9a58fc5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
qiankun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2023 8:22am

@kuitos kuitos requested review from aladdin-add and gongshun August 23, 2023 07:55
aladdin-add
aladdin-add approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@kuitos kuitos merged commit 7328396 into master Aug 23, 2023
@kuitos kuitos deleted the fix/vconsole branch August 23, 2023 08:41
@kuitos kuitos mentioned this pull request Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aladdin-add aladdin-add aladdin-add approved these changes

@gongshun gongshun Awaiting requested review from gongshun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kuitos @aladdin-add